zig/mach
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

object: when cleaning up dropped items, only re-add ones that aren't already in the recycle bin. (#1324)

Browse source 
Signed-off-by: Aeden McClain <dev@platypro.net>
This commit is contained in:
Aeden McClain 2024-12-30 10:15:15 -08:00 • committed by GitHub
parent 6450e8abbf
commit 04d7238383
Failed to generate hash of commit
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/module.zig
View file

@ -140,7 +140,14 @@ pub fn Objects(options: ObjectsOptions, comptime T: type) type {
// recycling bin to fit them. // recycling bin to fit them.
if (objs.internal.thrown_on_the_floor >= (data.len / 10)) { if (objs.internal.thrown_on_the_floor >= (data.len / 10)) {
var iter = dead.iterator(.{ .kind = .set }); var iter = dead.iterator(.{ .kind = .set });
while (iter.next()) |index| { dead_object_loop: while (iter.next()) |index| {
// We need to check if this index is already in the recycling bin since
// if it is, it could get recycled a second time while still
// in use.
for (recycling_bin.items) |recycled_index| {
if (index == recycled_index) continue :dead_object_loop;
}
// dead bitset contains data.capacity number of entries, we only care about ones that are in data.len range. // dead bitset contains data.capacity number of entries, we only care about ones that are in data.len range.
if (index > data.len - 1) break; if (index > data.len - 1) break;
try recycling_bin.append(allocator, @intCast(index)); try recycling_bin.append(allocator, @intCast(index));