From 2e7cb30bc95a0ccdab1d6a1eec28cf485c77c1fa Mon Sep 17 00:00:00 2001 From: Stephen Gutekanst Date: Wed, 27 Mar 2024 06:48:00 -0700 Subject: [PATCH] module: invert switch case for hypothetically better branch prediction Signed-off-by: Stephen Gutekanst --- src/module.zig | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/module.zig b/src/module.zig index cb0efe78..7cd020da 100644 --- a/src/module.zig +++ b/src/module.zig @@ -298,11 +298,10 @@ pub fn Modules(comptime mods: anytype) type { /// Call local event handler with the specified name in the specified module inline fn callLocal(module_name: ModuleName(mods), event_name: LocalEvent, args: []u8, injectable: anytype) !void { if (@typeInfo(@TypeOf(event_name)).Enum.fields.len == 0) return; - // TODO: invert switch case for hypothetically better branch prediction - switch (module_name) { - inline else => |mod_name| { - switch (event_name) { - inline else => |ev_name| { + switch (event_name) { + inline else => |ev_name| { + switch (module_name) { + inline else => |mod_name| { const M = @field(NamespacedModules(@This().modules){}, @tagName(mod_name)); _ = ModuleInterface(M); // Validate the module