From 9ed542bd7e8f725627f38ef8071016e309233e5a Mon Sep 17 00:00:00 2001
From: Stephen Gutekanst <stephen@hexops.com>
Date: Thu, 11 Aug 2022 06:17:38 -0700
Subject: [PATCH] gpu: make Queue.writeBuffer use a slice helper

Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
---
 gpu/README.md     |  2 +-
 gpu/src/queue.zig | 22 ++++++++++++++++------
 2 files changed, 17 insertions(+), 7 deletions(-)

diff --git a/gpu/README.md b/gpu/README.md
index 2698af8b..93b98534 100644
--- a/gpu/README.md
+++ b/gpu/README.md
@@ -153,6 +153,7 @@ The slice helpers are:
 
 * `Adapter.enumerateFeaturesOwned`
 * `Queue.writeTexture`
+* `Queue.writeBuffer`
 
 ### Typed callbacks
 
@@ -219,7 +220,6 @@ The following are definitive candidates for helpers we haven't implemented yet:
 * `gpu.CommandEncoder.writeBuffer` (slices)
 * `gpu.ComputePassEncoder.setBindGroup` (slice param)
 * `gpu.Device.enumerateFeatures` (owned slice)
-* `gpu.Queue.writeBuffer` (slices)
 * `gpu.RenderBundleEncoder.setBindGroup` (slice param)
 * `gpu.RenderPassEncoder.executeBundles` (slice param)
 * `gpu.RenderPassEncoder.setBindGroup` (slice param)
diff --git a/gpu/src/queue.zig b/gpu/src/queue.zig
index b955eb2f..5befe61f 100644
--- a/gpu/src/queue.zig
+++ b/gpu/src/queue.zig
@@ -53,8 +53,19 @@ pub const Queue = opaque {
         Impl.queueSubmit(queue, @intCast(u32, commands.len), commands.ptr);
     }
 
-    pub inline fn writeBuffer(queue: *Queue, buffer: *Buffer, buffer_offset: u64, data: *anyopaque, size: usize) void {
-        Impl.queueWriteBuffer(queue, buffer, buffer_offset, data, size);
+    pub inline fn writeBuffer(
+        queue: *Queue,
+        buffer: *Buffer,
+        buffer_offset_bytes: u64,
+        data_slice: anytype,
+    ) void {
+        Impl.queueWriteBuffer(
+            queue,
+            buffer,
+            buffer_offset_bytes,
+            @ptrCast(*const anyopaque, data_slice.ptr),
+            @intCast(u64, data_slice.len) * @sizeOf(std.meta.Elem(@TypeOf(data_slice))),
+        );
     }
 
     pub inline fn writeTexture(
@@ -62,14 +73,13 @@ pub const Queue = opaque {
         destination: *const ImageCopyTexture,
         data_layout: *const Texture.DataLayout,
         write_size: *const Extent3D,
-        comptime T: type,
-        data: []const T,
+        data_slice: anytype,
     ) void {
         Impl.queueWriteTexture(
             queue,
             destination,
-            @ptrCast(*const anyopaque, data.ptr),
-            @intCast(usize, data.len) * @sizeOf(std.meta.Elem(@TypeOf(data))),
+            @ptrCast(*const anyopaque, data_slice.ptr),
+            @intCast(usize, data_slice.len) * @sizeOf(std.meta.Elem(@TypeOf(data_slice))),
             data_layout,
             write_size,
         );