From b8c913cd6cf8e160fc1d680eac64f82f990a8e83 Mon Sep 17 00:00:00 2001 From: InKryption <59504965+InKryption@users.noreply.github.com> Date: Tue, 7 Dec 2021 11:46:26 +0100 Subject: [PATCH] glfw: remove TODOs --- glfw/src/Window.zig | 3 --- glfw/src/main.zig | 3 --- 2 files changed, 6 deletions(-) diff --git a/glfw/src/Window.zig b/glfw/src/Window.zig index 159aace7..0608cf87 100644 --- a/glfw/src/Window.zig +++ b/glfw/src/Window.zig @@ -1422,9 +1422,6 @@ pub inline fn setPosCallback(self: Window, callback: ?fn (window: Window, xpos: }; } -// TODO: don't the calls to `from` in these `set*CallbackWrapper` functions cause a leak? -// is this what's being reported by valgrind in [#60](https://github.com/hexops/mach/issues/60)? - fn setSizeCallbackWrapper(handle: ?*c.GLFWwindow, width: c_int, height: c_int) callconv(.C) void { internal_debug.assertInitialized(); const window = from(handle.?) catch unreachable; diff --git a/glfw/src/main.zig b/glfw/src/main.zig index 0a30efce..20f2c713 100644 --- a/glfw/src/main.zig +++ b/glfw/src/main.zig @@ -92,9 +92,6 @@ pub inline fn init(hints: InitHints) error{PlatformError}!void { /// /// Possible errors include glfw.Error.PlatformError. /// -// TODO: Should this remark be removed? Or should we allow this function to be called before init? -/// remark: This function may be called before glfw.init. -/// /// warning: The contexts of any remaining windows must not be current on any other thread when /// this function is called. ///