From be402d4b6df55fc23f1b2af3153d1d6d75648fa7 Mon Sep 17 00:00:00 2001
From: Stephen Gutekanst <stephen@hexops.com>
Date: Sun, 31 Jul 2022 11:00:28 -0700
Subject: [PATCH] gpu: add TODOs about unsetting callbacks

Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
---
 gpu/src/device.zig | 41 +++++++++++++++++++++++++++++++++++------
 1 file changed, 35 insertions(+), 6 deletions(-)

diff --git a/gpu/src/device.zig b/gpu/src/device.zig
index c047fd78..b64eb3fc 100644
--- a/gpu/src/device.zig
+++ b/gpu/src/device.zig
@@ -67,7 +67,12 @@ pub const Device = opaque {
         return Impl.deviceCreateComputePipeline(device, descriptor);
     }
 
-    pub inline fn createComputePipelineAsync(device: *Device, descriptor: *const ComputePipeline.Descriptor, callback: CreateComputePipelineAsyncCallback, userdata: ?*anyopaque) void {
+    pub inline fn createComputePipelineAsync(
+        device: *Device,
+        descriptor: *const ComputePipeline.Descriptor,
+        callback: CreateComputePipelineAsyncCallback,
+        userdata: ?*anyopaque,
+    ) void {
         Impl.deviceCreateComputePipelineAsync(device, descriptor, callback, userdata);
     }
 
@@ -99,7 +104,12 @@ pub const Device = opaque {
         return Impl.deviceCreateRenderPipeline(device, descriptor);
     }
 
-    pub inline fn createRenderPipelineAsync(device: *Device, descriptor: *const RenderPipeline.Descriptor, callback: CreateRenderPipelineAsyncCallback, userdata: ?*anyopaque) void {
+    pub inline fn createRenderPipelineAsync(
+        device: *Device,
+        descriptor: *const RenderPipeline.Descriptor,
+        callback: CreateRenderPipelineAsyncCallback,
+        userdata: ?*anyopaque,
+    ) void {
         Impl.deviceCreateRenderPipelineAsync(device, descriptor, callback, userdata);
     }
 
@@ -147,7 +157,11 @@ pub const Device = opaque {
         Impl.deviceLoseForTesting(device);
     }
 
-    pub inline fn popErrorScope(device: *Device, callback: ErrorCallback, userdata: ?*anyopaque) bool {
+    pub inline fn popErrorScope(
+        device: *Device,
+        callback: ErrorCallback,
+        userdata: ?*anyopaque,
+    ) bool {
         return Impl.devicePopErrorScope(device, callback, userdata);
     }
 
@@ -155,7 +169,12 @@ pub const Device = opaque {
         Impl.devicePushErrorScope(device, filter);
     }
 
-    pub inline fn setDeviceLostCallback(device: *Device, callback: Device.LostCallback, userdata: ?*anyopaque) void {
+    // TODO: presumably callback should be nullable for unsetting
+    pub inline fn setDeviceLostCallback(
+        device: *Device,
+        callback: Device.LostCallback,
+        userdata: ?*anyopaque,
+    ) void {
         Impl.deviceSetDeviceLostCallback(device, callback, userdata);
     }
 
@@ -163,11 +182,21 @@ pub const Device = opaque {
         Impl.deviceSetLabel(device, label);
     }
 
-    pub inline fn setLoggingCallback(device: *Device, callback: LoggingCallback, userdata: ?*anyopaque) void {
+    // TODO: presumably callback should be nullable for unsetting
+    pub inline fn setLoggingCallback(
+        device: *Device,
+        callback: LoggingCallback,
+        userdata: ?*anyopaque,
+    ) void {
         Impl.deviceSetLoggingCallback(device, callback, userdata);
     }
 
-    pub inline fn setUncapturedErrorCallback(device: *Device, callback: ErrorCallback, userdata: ?*anyopaque) void {
+    // TODO: presumably callback should be nullable for unsetting
+    pub inline fn setUncapturedErrorCallback(
+        device: *Device,
+        callback: ErrorCallback,
+        userdata: ?*anyopaque,
+    ) void {
         Impl.deviceSetUncapturedErrorCallback(device, callback, userdata);
     }