From cfc9708b37a0bd7348661bd14729a76bcd23e9a0 Mon Sep 17 00:00:00 2001 From: Stephen Gutekanst Date: Fri, 18 Mar 2022 22:56:46 -0700 Subject: [PATCH] gpu: update remaining TODOs Signed-off-by: Stephen Gutekanst --- gpu/src/NativeInstance.zig | 4 ++-- gpu/src/Queue.zig | 2 +- gpu/src/TODO | 7 ------- 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/gpu/src/NativeInstance.zig b/gpu/src/NativeInstance.zig index 41852af8..b51cb9fe 100644 --- a/gpu/src/NativeInstance.zig +++ b/gpu/src/NativeInstance.zig @@ -1896,8 +1896,8 @@ const command_encoder_vtable = CommandEncoder.VTable{ .stencilReadOnly = v.stencil_read_only, } else null, .occlusionQuerySet = if (d.occlusion_query_set) |v| @ptrCast(c.WGPUQuerySet, v.ptr) else null, - .timestampWriteCount = 0, // TODO - .timestampWrites = null, // TODO + .timestampWriteCount = 0, // TODO(implement) + .timestampWrites = null, // TODO(implement) }; return wrapRenderPassEncoder(c.wgpuCommandEncoderBeginRenderPass(@ptrCast(c.WGPUCommandEncoder, ptr), &desc)); } diff --git a/gpu/src/Queue.zig b/gpu/src/Queue.zig index 5035e680..7dd42f29 100644 --- a/gpu/src/Queue.zig +++ b/gpu/src/Queue.zig @@ -15,7 +15,7 @@ pub const VTable = struct { // TODO: dawn specific? // copyTextureForBrowser: fn (ptr: *anyopaque, source: *const ImageCopyTexture, destination: *const ImageCopyTexture, copy_size: *const Extent3D, options: *const CopyTextureForBrowserOptions) void, submit: fn (queue: Queue, commands: []const CommandBuffer) void, - // TODO: + // TODO(implement): // writeBuffer: fn (ptr: *anyopaque, buffer: Buffer, buffer_offset: u64, data: *const anyopaque, size: usize); // writeTexture: fn (ptr: *anyopaque, destination: *const ImageCopyTexture, data: *const anyopaque, data_size: usize, data_layout: *const TextureDataLayout, write_size: *const Extent3D); }; diff --git a/gpu/src/TODO b/gpu/src/TODO index e3e6b2c4..2e3d8ab8 100644 --- a/gpu/src/TODO +++ b/gpu/src/TODO @@ -44,13 +44,6 @@ typedef struct WGPUCopyTextureForBrowserOptions { WGPUAlphaMode dstAlphaMode; } WGPUCopyTextureForBrowserOptions; - - -typedef void (*WGPUDeviceLostCallback)(WGPUDeviceLostReason reason, char const * message, void * userdata); -typedef void (*WGPUErrorCallback)(WGPUErrorType type, char const * message, void * userdata); -typedef void (*WGPULoggingCallback)(WGPULoggingType type, char const * message, void * userdata); -typedef void (*WGPUProc)(); - typedef enum WGPUSType { // webgpu.h upstream: WGPUSType_Invalid = 0x00000000,