zig/mach
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gpu: correct bufferGet*MappedRange (incorrect comment in Dawn)

Browse source 
Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
This commit is contained in:
Stephen Gutekanst 2022-07-26 20:48:35 -07:00 • committed by Stephen Gutekanst
parent 6961700b94
commit e04864d553
2 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
gpu/src/buffer.zig
View file

@ -8,11 +8,11 @@ pub const Buffer = *opaque {
impl.bufferDestroy(buffer);
}
pub inline fn bufferGetConstMappedRange(buffer: Buffer, offset: usize, size: usize) *const anyopaque {
pub inline fn bufferGetConstMappedRange(buffer: Buffer, offset: usize, size: usize) ?*const anyopaque {
return impl.bufferGetConstMappedRange(buffer, offset, size);
}
pub inline fn bufferGetMappedRange(buffer: Buffer, offset: usize, size: usize) *anyopaque {
pub inline fn bufferGetMappedRange(buffer: Buffer, offset: usize, size: usize) ?*anyopaque {
return impl.bufferGetMappedRange(buffer, offset, size);
}

16
gpu/src/interface.zig
View file

@ -34,8 +34,8 @@ pub fn Interface(comptime Impl: type) type {
assertDecl(Impl, "bindGroupLayoutReference", fn (bind_group_layout: gpu.BindGroupLayout) callconv(.Inline) void);
assertDecl(Impl, "bindGroupLayoutRelease", fn (bind_group_layout: gpu.BindGroupLayout) callconv(.Inline) void);
assertDecl(Impl, "bufferDestroy", fn (buffer: gpu.Buffer) callconv(.Inline) void);
assertDecl(Impl, "bufferGetConstMappedRange", fn (buffer: gpu.Buffer, offset: usize, size: usize) callconv(.Inline) *const anyopaque);
assertDecl(Impl, "bufferGetMappedRange", fn (buffer: gpu.Buffer, offset: usize, size: usize) callconv(.Inline) *anyopaque);
assertDecl(Impl, "bufferGetConstMappedRange", fn (buffer: gpu.Buffer, offset: usize, size: usize) callconv(.Inline) ?*const anyopaque);
assertDecl(Impl, "bufferGetMappedRange", fn (buffer: gpu.Buffer, offset: usize, size: usize) callconv(.Inline) ?*anyopaque);
assertDecl(Impl, "bufferGetSize", fn (buffer: gpu.Buffer) callconv(.Inline) u64);
assertDecl(Impl, "bufferGetUsage", fn (buffer: gpu.Buffer) callconv(.Inline) gpu.BufferUsage);
assertDecl(Impl, "bufferMapAsync", fn (buffer: gpu.Buffer, mode: gpu.MapMode, offset: usize, size: usize, callback: gpu.BufferMapCallback, userdata: *anyopaque) callconv(.Inline) void);
@ -318,12 +318,12 @@ pub fn Export(comptime Impl: type) type {
}
// WGPU_EXPORT void const * wgpuBufferGetConstMappedRange(WGPUBuffer buffer, size_t offset, size_t size);
export fn wgpuBufferGetConstMappedRange(buffer: gpu.Buffer, offset: usize, size: usize) *const anyopaque {
export fn wgpuBufferGetConstMappedRange(buffer: gpu.Buffer, offset: usize, size: usize) ?*const anyopaque {
return Impl.bufferGetConstMappedRange(buffer, offset, size);
}
// WGPU_EXPORT void * wgpuBufferGetMappedRange(WGPUBuffer buffer, size_t offset, size_t size);
export fn wgpuBufferGetMappedRange(buffer: gpu.Buffer, offset: usize, size: usize) *anyopaque {
export fn wgpuBufferGetMappedRange(buffer: gpu.Buffer, offset: usize, size: usize) ?*anyopaque {
return Impl.bufferGetMappedRange(buffer, offset, size);
}
@ -1341,16 +1341,16 @@ pub const StubInterface = Interface(struct {
unreachable;
}
// TODO: should return nullable; bug in Dawn docstrings!
pub inline fn bufferGetConstMappedRange(buffer: gpu.Buffer, offset: usize, size: usize) *const anyopaque {
// TODO: should return nullable; file bug in Dawn docstrings!
pub inline fn bufferGetConstMappedRange(buffer: gpu.Buffer, offset: usize, size: usize) ?*const anyopaque {
_ = buffer;
_ = offset;
_ = size;
unreachable;
}
// TODO: should return nullable; bug in Dawn docstrings!
pub inline fn bufferGetMappedRange(buffer: gpu.Buffer, offset: usize, size: usize) *anyopaque {
// TODO: should return nullable; file bug in Dawn docstrings!
pub inline fn bufferGetMappedRange(buffer: gpu.Buffer, offset: usize, size: usize) ?*anyopaque {
_ = buffer;
_ = offset;
_ = size;