From f366244a9a2b8fc139ed63c63fd4a55c9be63570 Mon Sep 17 00:00:00 2001 From: Stephen Gutekanst Date: Tue, 16 Aug 2022 10:46:44 -0700 Subject: [PATCH] gpu: add TODOs for slice helper candidates Signed-off-by: Stephen Gutekanst --- gpu/src/bind_group.zig | 1 + gpu/src/bind_group_layout.zig | 1 + gpu/src/compute_pass_encoder.zig | 1 - gpu/src/dawn.zig | 3 +++ gpu/src/device.zig | 1 + gpu/src/pipeline_layout.zig | 1 + gpu/src/query_set.zig | 1 + gpu/src/render_bundle_encoder.zig | 2 +- gpu/src/texture.zig | 1 + gpu/src/types.zig | 10 ++++++++++ 10 files changed, 20 insertions(+), 2 deletions(-) diff --git a/gpu/src/bind_group.zig b/gpu/src/bind_group.zig index 37d03508..a1aa9ef4 100644 --- a/gpu/src/bind_group.zig +++ b/gpu/src/bind_group.zig @@ -48,6 +48,7 @@ pub const BindGroup = opaque { next_in_chain: ?*const ChainedStruct = null, label: ?[*:0]const u8 = null, layout: *BindGroupLayout, + // TODO: slice helper entry_count: u32 = 0, entries: ?[*]const Entry = null, }; diff --git a/gpu/src/bind_group_layout.zig b/gpu/src/bind_group_layout.zig index 5cf0a91c..c6cc2022 100644 --- a/gpu/src/bind_group_layout.zig +++ b/gpu/src/bind_group_layout.zig @@ -92,6 +92,7 @@ pub const BindGroupLayout = opaque { pub const Descriptor = extern struct { next_in_chain: ?*const ChainedStruct = null, label: ?[*:0]const u8 = null, + // TODO: slice helper entry_count: u32 = 0, entries: ?[*]const Entry = null, }; diff --git a/gpu/src/compute_pass_encoder.zig b/gpu/src/compute_pass_encoder.zig index 1d7481e9..7feb28bf 100644 --- a/gpu/src/compute_pass_encoder.zig +++ b/gpu/src/compute_pass_encoder.zig @@ -31,7 +31,6 @@ pub const ComputePassEncoder = opaque { Impl.computePassEncoderPushDebugGroup(compute_pass_encoder, group_label); } - /// Default `dynamic_offset_count`: 0 /// Default `dynamic_offsets`: null pub inline fn setBindGroup(compute_pass_encoder: *ComputePassEncoder, group_index: u32, group: *BindGroup, dynamic_offsets: ?[]const u32) void { Impl.computePassEncoderSetBindGroup( diff --git a/gpu/src/dawn.zig b/gpu/src/dawn.zig index 99762363..01ed55c9 100644 --- a/gpu/src/dawn.zig +++ b/gpu/src/dawn.zig @@ -17,6 +17,7 @@ pub const EncoderInternalUsageDescriptor = extern struct { /// TODO: Can be chained in gpu.Instance.Descriptor pub const InstanceDescriptor = extern struct { chain: ChainedStruct, + // TODO: slice helper additional_runtime_search_paths_count: u32 = 0, additional_runtime_search_paths: ?[*]const u8 = null, }; @@ -30,8 +31,10 @@ pub const TextureInternalUsageDescriptor = extern struct { /// TODO: Can be chained in gpu.Device.Descriptor pub const TogglesDeviceDescriptor = extern struct { chain: ChainedStruct, + // TODO: slice helper force_enabled_toggles_count: u32 = 0, force_enabled_toggles: ?[*]const u8 = null, + // TODO: slice helper force_disabled_toggles_count: u32 = 0, force_disabled_toggles: ?[*]const u8 = null, }; diff --git a/gpu/src/device.zig b/gpu/src/device.zig index 08a3f036..21f8d4f2 100644 --- a/gpu/src/device.zig +++ b/gpu/src/device.zig @@ -44,6 +44,7 @@ pub const Device = opaque { pub const Descriptor = extern struct { next_in_chain: ?*const ChainedStruct = null, label: ?[*:0]const u8 = null, + // TODO: slice helper required_features_count: u32 = 0, required_features: ?[*]const FeatureName = null, required_limits: ?*const RequiredLimits = null, diff --git a/gpu/src/pipeline_layout.zig b/gpu/src/pipeline_layout.zig index a5c6820a..5f88217e 100644 --- a/gpu/src/pipeline_layout.zig +++ b/gpu/src/pipeline_layout.zig @@ -6,6 +6,7 @@ pub const PipelineLayout = opaque { pub const Descriptor = extern struct { next_in_chain: ?*const ChainedStruct = null, label: ?[*:0]const u8 = null, + // TODO: slice helper bind_group_layout_count: u32 = 0, bind_group_layouts: ?[*]const *BindGroupLayout = null, }; diff --git a/gpu/src/query_set.zig b/gpu/src/query_set.zig index f076cdaf..62100cdd 100644 --- a/gpu/src/query_set.zig +++ b/gpu/src/query_set.zig @@ -9,6 +9,7 @@ pub const QuerySet = opaque { label: ?[*:0]const u8 = null, type: QueryType, count: u32, + // TODO: slice helper pipeline_statistics: ?[*]const PipelineStatisticName = null, pipeline_statistics_count: u32 = 0, }; diff --git a/gpu/src/render_bundle_encoder.zig b/gpu/src/render_bundle_encoder.zig index f915b0ea..ae879be8 100644 --- a/gpu/src/render_bundle_encoder.zig +++ b/gpu/src/render_bundle_encoder.zig @@ -11,6 +11,7 @@ pub const RenderBundleEncoder = opaque { pub const Descriptor = extern struct { next_in_chain: ?*const ChainedStruct = null, label: ?[*:0]const u8 = null, + // TODO: slice helper color_formats_count: u32 = 0, color_formats: ?[*]const Texture.Format = null, depth_stencil_format: Texture.Format = .undef, @@ -58,7 +59,6 @@ pub const RenderBundleEncoder = opaque { Impl.renderBundleEncoderPushDebugGroup(render_bundle_encoder, group_label); } - /// Default `dynamic_offsets_count`: 0 /// Default `dynamic_offsets`: `null` pub inline fn setBindGroup(render_bundle_encoder: *RenderBundleEncoder, group_index: u32, group: *BindGroup, dynamic_offsets: ?[]const u32) void { Impl.renderBundleEncoderSetBindGroup( diff --git a/gpu/src/texture.zig b/gpu/src/texture.zig index e47dca41..499514c9 100644 --- a/gpu/src/texture.zig +++ b/gpu/src/texture.zig @@ -182,6 +182,7 @@ pub const Texture = opaque { format: Format, mip_level_count: u32 = 1, sample_count: u32 = 1, + // TODO: slice helper view_format_count: u32 = 0, view_formats: ?[*]const Format = null, }; diff --git a/gpu/src/types.zig b/gpu/src/types.zig index 451b3383..e7c48651 100644 --- a/gpu/src/types.zig +++ b/gpu/src/types.zig @@ -57,6 +57,7 @@ pub const RequestAdapterOptions = extern struct { pub const ComputePassDescriptor = extern struct { next_in_chain: ?*const ChainedStruct = null, label: ?[*:0]const u8 = null, + // TODO: slice helper timestamp_write_count: u32 = 0, timestamp_writes: ?[*]const ComputePassTimestampWrite = null, }; @@ -64,10 +65,12 @@ pub const ComputePassDescriptor = extern struct { pub const RenderPassDescriptor = extern struct { next_in_chain: ?*const ChainedStruct = null, label: ?[*:0]const u8 = null, + // TODO: slice helper color_attachment_count: u32 = 0, color_attachments: ?[*]const RenderPassColorAttachment = null, depth_stencil_attachment: ?*const RenderPassDepthStencilAttachment = null, occlusion_query_set: ?*QuerySet = null, + // TODO: slice helper timestamp_write_count: u32 = 0, timestamp_writes: ?[*]const RenderPassTimestampWrite = null, }; @@ -583,6 +586,7 @@ pub const BlendState = extern struct { pub const CompilationInfo = extern struct { next_in_chain: ?*const ChainedStruct = null, + // TODO: slice helper message_count: u32, messages: ?[*]const CompilationMessage = null, }; @@ -619,6 +623,7 @@ pub const ProgrammableStageDescriptor = extern struct { next_in_chain: ?*const ChainedStruct = null, module: *ShaderModule, entry_point: [*:0]const u8, + // TODO: slice helper constant_count: u32 = 0, constants: ?[*]const ConstantEntry = null, }; @@ -651,6 +656,7 @@ pub const SupportedLimits = extern struct { pub const VertexBufferLayout = extern struct { array_stride: u64, step_mode: VertexStepMode = .vertex, + // TODO: slice helper attribute_count: u32, attributes: ?[*]const VertexAttribute = null, }; @@ -666,8 +672,10 @@ pub const VertexState = extern struct { next_in_chain: ?*const ChainedStruct = null, module: *ShaderModule, entry_point: [*:0]const u8, + // TODO: slice helper constant_count: u32 = 0, constants: ?[*]const ConstantEntry = null, + // TODO: slice helper buffer_count: u32 = 0, buffers: ?[*]const VertexBufferLayout = null, }; @@ -676,8 +684,10 @@ pub const FragmentState = extern struct { next_in_chain: ?*const ChainedStruct = null, module: *ShaderModule, entry_point: [*:0]const u8, + // TODO: slice helper constant_count: u32 = 0, constants: ?[*]const ConstantEntry = null, + // TODO: slice helper target_count: u32, targets: ?[*]const ColorTargetState = null, };