zig/mach
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

glfw: remove TODOs

Browse source
This commit is contained in:
InKryption 2021-12-07 11:46:26 +01:00 • committed by Stephen Gutekanst
parent 9ea4d2aa6f
commit b8c913cd6c
2 changed files with 0 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
glfw/src/Window.zig
View file

@ -1422,9 +1422,6 @@ pub inline fn setPosCallback(self: Window, callback: ?fn (window: Window, xpos:
}; };
} }
// TODO: don't the calls to `from` in these `set*CallbackWrapper` functions cause a leak?
// is this what's being reported by valgrind in [#60](https://github.com/hexops/mach/issues/60)?
fn setSizeCallbackWrapper(handle: ?*c.GLFWwindow, width: c_int, height: c_int) callconv(.C) void { fn setSizeCallbackWrapper(handle: ?*c.GLFWwindow, width: c_int, height: c_int) callconv(.C) void {
internal_debug.assertInitialized(); internal_debug.assertInitialized();
const window = from(handle.?) catch unreachable; const window = from(handle.?) catch unreachable;

3
glfw/src/main.zig
View file

@ -92,9 +92,6 @@ pub inline fn init(hints: InitHints) error{PlatformError}!void {
/// ///
/// Possible errors include glfw.Error.PlatformError. /// Possible errors include glfw.Error.PlatformError.
/// ///
// TODO: Should this remark be removed? Or should we allow this function to be called before init?
/// remark: This function may be called before glfw.init.
///
/// warning: The contexts of any remaining windows must not be current on any other thread when /// warning: The contexts of any remaining windows must not be current on any other thread when
/// this function is called. /// this function is called.
/// ///